Fix: Fix errors related to navigation #1623
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koc
commented
Feb 19, 2025
| @@ -85,20 +88,20 @@ export default { | |||
| this.setActiveTableId(parseInt(currentRoute.params.tableId)) | |||
| this.setPageTitle(this.activeTable.title) | |||
| if (!currentRoute.path.includes('/row/')) { | |||
| this.switchActiveMenuEntry(document.querySelector('header .header-left .app-menu a[title="Tables"]')) | |||
| this.switchActiveMenuEntry(document.querySelector(`header .header-start .app-menu a[href="${url}"]`)) | |||
There was a problem hiding this comment.
If you have any other idea how to make it works for non-en locales - feel free to suggest
There was a problem hiding this comment.
It can looks like:
if (currentRoute.path.startsWith('/table/')) {
this.setActiveTableId(parseInt(currentRoute.params.tableId))
this.setPageTitle(this.activeTable.title)
if (!currentRoute.path.includes('/row/')) {
emit('nextcloud:app-menu.active', 'tables')
}
enjeck
reviewed
Feb 20, 2025
There was a problem hiding this comment.
I started trying to also fix these errors at #1477. We've had to fix these multiple times whenever the classnames change, and have been thinking of a more stable solution. There's a suggestion #1477 (comment) to consider using a server API, that I'm yet to look at.
Signed-off-by: Kostiantyn Miakshyn <[email protected]>
Koc
force-pushed
the
bugfix/fix-app-navigation
branch
from
dff1dbb to
58b7100
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we have 2 annoying errors in console. This pr fixes both of them. Includes #1477.